pjfanning commented on code in PR #541: URL: https://github.com/apache/incubator-pekko/pull/541#discussion_r1285098738
########## CONTRIBUTING.md: ########## @@ -298,13 +298,13 @@ For a pull request to be considered at all, it has to meet these requirements: 1. A pull request must be [linked to the issue](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue) it aims to resolve in the PR's description (or comments). This can be achieved by writing "Fixes #1234" or similar in PR description. 1. Licensing rules: - Existing files with copyright statements must leave those copyright statements intact - - New files should have an Apache license header instead. For an example of this, see [this file](https://github.com/apache/poi/blob/trunk/poi/src/main/java/org/apache/poi/POIDocument.java). + - New files should have an Apache license header instead. For an example of this, see [this file](https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/SparkContext.scala). Review Comment: * it's just a link to a file with an Apache header in the format that we want it in * it's not an endorsement of Spark or Flink * It might be nice to have a list of tools that use Pekko but that should be its own page -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
