pjfanning opened a new pull request, #295:
URL: https://github.com/apache/incubator-pekko-http/pull/295
problems with #294
* I added a stray `"` into the regex
* the Group match has to handle 3 extra subgroups that the regex change
brings in
* for `1.1.0-M0+22-4f570ea2-SNAPSHOT`, the 3 extra subgroups are `-M0`,
`-M`, `0`
* if there is no `-M0` (or `-RC0`), the extra subgroups are all null
* the sorting will do for now but it doesn't take into account whether the
tag is M or RC and there are other problems
* I did play around with sbt.librarymanagement.VersionNumber but it doesn't
have a comparator (or scala.Ordering implementation).
* I will try this again to see if I can create my own comparator for
sbt.librarymanagement.VersionNumber
* using this PR to get the build working for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
