pjfanning commented on code in PR #142:
URL:
https://github.com/apache/incubator-pekko-grpc/pull/142#discussion_r1285741344
##########
gradle-plugin/build.gradle:
##########
@@ -23,18 +23,43 @@ gradlePlugin {
}
}
-pluginBundle {
- website = 'https://pekko.apache.org/docs/pekko-grpc/current/'
- vcsUrl = 'https://github.com/apache/incubator-pekko-grpc'
- description = 'Building streaming gRPC servers and clients on top of Apache
Pekko Streams'
- tags = ['pekko', 'streams', 'reactive']
+publishing {
+ publications.withType(MavenPublication) {
+ pom {
+ name = "pekko-grpc-gradle-plugin"
+ description = "Apache Pekko gRPC - Support for building streaming
gRPC servers and clients on top of Pekko Streams."
+ url = "https://pekko.apache.org/";
+ licenses {
+ license {
+ name = "Apache-2.0"
+ url = "https://www.apache.org/licenses/LICENSE-2.0.html";
+ }
+ }
+ developers {
+ developer {
+ id = 'contributors'
+ name = 'Contributors'
+ url =
'https://github.com/apache/incubator-pekko-grpc/graphs/contributors'
+ email = '[email protected]'
+ }
+ }
+ scm {
+ connection = '[email protected]:apache/incubator-pekko-grpc'
+ url = 'https://github.com/apache/incubator-pekko-grpc'
+ }
+ }
+ }
+}
- plugins {
- pekkoGrpcPlugin {
- id = 'org.apache.pekko.grpc.gradle'
- displayName = 'Apache Pekko gRPC'
+nexusPublishing {
+ repositories {
+ sonatype {
+ nexusUrl.set(uri("https://repository.apache.org/";))
+
snapshotRepositoryUrl.set(uri("https://repository.apache.org/content/repositories/snapshots/";))
Review Comment:
you've hardcoded a snapshot url into this publish section so I do not see
how this publish can handle when we need to do a non-snapshot release - we are
actually waiting to do a release on this very repo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
