mdedetrich commented on issue #548: URL: https://github.com/apache/incubator-pekko/issues/548#issuecomment-1669046907
> That's was a quick fix so I duplicated the code to keep night build runing. Understood and fine for now > For future, we should extract all shared plugins to something as what you once suggested and [typelevel ](https://github.com/typelevel/sbt-typelevel)does, eg: apache-sbt-pekko? This makes sense for features that are unique to pekko, i.e. think our Paradox theme or setting up the organization of our projects to `org.apache.pekko`. sbt-multi-jvm however is just a general feature so it makes more sense if its possible to use sbt-multi-jvm. This isn't any different to sbt-license-report, which our Pekko projects use but is an sbt community plugin (see https://github.com/sbt/sbt-license-report) and if you look at https://github.com/sbt/sbt-license-report/pulls?q=is%3Apr+author%3Amdedetrich and https://github.com/sbt/sbt-license-report/releases you can see that contributing upsream and getting a release wasn't an issue at all. As I said before, generally speaking if its shown that you contribute features upstream there isn't usually a problem in those releases being made. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
