He-Pin commented on code in PR #208:
URL:
https://github.com/apache/incubator-pekko-connectors/pull/208#discussion_r1294351147
##########
build.sbt:
##########
@@ -129,8 +129,8 @@ lazy val `pekko-connectors` = project
crossScalaVersions := List() // workaround for
https://github.com/sbt/sbt/issues/3465
)
-addCommandAlias("applyCodeStyle", ";scalafmtAll; scalafmtSbt; javafmtAll")
-addCommandAlias("checkCodeStyle", ";scalafmtCheckAll; scalafmtSbtCheck;
javafmtCheckAll")
+addCommandAlias("applyCodeStyle", ";scalafmtAll; scalafmtSbt; javafmtAll;
+headerCheckAll")
+addCommandAlias("checkCodeStyle", "+headerCreateAll; ;scalafmtCheckAll;
scalafmtSbtCheck; javafmtCheckAll")
Review Comment:
@mdedetrich maybe that wil confuse some one contribute to both project?I
mean akka & pekko, I saw @dongxuwang did the same too.
##########
build.sbt:
##########
@@ -129,8 +129,8 @@ lazy val `pekko-connectors` = project
crossScalaVersions := List() // workaround for
https://github.com/sbt/sbt/issues/3465
)
-addCommandAlias("applyCodeStyle", ";scalafmtAll; scalafmtSbt; javafmtAll")
-addCommandAlias("checkCodeStyle", ";scalafmtCheckAll; scalafmtSbtCheck;
javafmtCheckAll")
+addCommandAlias("applyCodeStyle", ";scalafmtAll; scalafmtSbt; javafmtAll;
+headerCheckAll")
+addCommandAlias("checkCodeStyle", "+headerCreateAll; ;scalafmtCheckAll;
scalafmtSbtCheck; javafmtCheckAll")
Review Comment:
@mdedetrich maybe that will confuse some one contribute to both project?I
mean akka & pekko, I saw @dongxuwang did the same too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
