jtjeferreira commented on code in PR #226:
URL:
https://github.com/apache/incubator-pekko-connectors/pull/226#discussion_r1298730541
##########
kinesis/src/main/scala/org/apache/pekko/stream/connectors/kinesis/impl/KinesisSchedulerSourceStage.scala:
##########
@@ -49,7 +49,7 @@ private[kinesis] object KinesisSchedulerSourceStage {
@InternalApi
private[kinesis] class KinesisSchedulerSourceStage(
settings: KinesisSchedulerSourceSettings,
- schedulerBuilder: ShardRecordProcessorFactory => Scheduler)(implicit ec:
ExecutionContext)
Review Comment:
So I added `println(Thread.currentThread().getName)` to the
`Future(scheduler.run())` like this:
```scala
Future{
println(Thread.currentThread().getName)
scheduler.run()
}
```
and ran the tests and I see `KinesisTests-pekko.actor.default-dispatcher-6`
being used
so this PR makes no difference...
If I add the `println` to the `onPull` method I see
`KinesisTests-pekko.actor.default-blocking-io-dispatcher-10` being used...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
