He-Pin commented on code in PR #603:
URL: https://github.com/apache/incubator-pekko/pull/603#discussion_r1311898120
##########
stream-tests/src/test/scala/org/apache/pekko/stream/scaladsl/FlowStatefulMapSpec.scala:
##########
@@ -280,4 +283,64 @@ class FlowStatefulMapSpec extends StreamSpec {
.expectComplete()
}
}
+
+ "won't call onComplete twice when downstream cancelled even if onComplete
throws" in {
+ var counter = 0
Review Comment:
Make use of AtomicInteger, as the stream can be run on a separated thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
