mdedetrich commented on PR #607: URL: https://github.com/apache/incubator-pekko/pull/607#issuecomment-1702261949
I am not sure we should be cherry picking this PR's onto the `1.0.x` branch. While I understand this fix is largely harmless it sends the wrong impression on the goals of the branch, which is that it is meant to be, as much as possible, a largely untouched version of Akka 2.6 just before BSL changes. Improvements to areas such as the build (sbt), formatting etc etc are fine and welcome since they don't actually effect the actual runtime behaviour of Pekko but unless we are dealing with CVE's, critical bugs or possible migration features to help people move off Akka we shouldn't be backporting such fixes. @pjfanning wdyt? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
