mdedetrich commented on code in PR #606:
URL: https://github.com/apache/incubator-pekko/pull/606#discussion_r1312630518
##########
stream/src/main/scala/org/apache/pekko/stream/javadsl/Flow.scala:
##########
@@ -773,6 +773,9 @@ final class Flow[In, Out, Mat](delegate: scaladsl.Flow[In,
Out, Mat]) extends Gr
* The returned `Iterable` MUST NOT contain `null` values,
* as they are illegal as stream elements - according to the Reactive
Streams specification.
*
+ * This operator doesn't handle upstream's completion signal, the state kept
in the closure can be lost,
Review Comment:
Minor nit, but this sounds better
> This operator doesn't handle upstream's completion signal since the state
kept in the closure can be lost. Use [[FlowOps.statefulMap]] instead.
##########
stream/src/main/scala/org/apache/pekko/stream/javadsl/Flow.scala:
##########
@@ -773,6 +773,9 @@ final class Flow[In, Out, Mat](delegate: scaladsl.Flow[In,
Out, Mat]) extends Gr
* The returned `Iterable` MUST NOT contain `null` values,
* as they are illegal as stream elements - according to the Reactive
Streams specification.
*
+ * This operator doesn't handle upstream's completion signal, the state kept
in the closure can be lost,
Review Comment:
Minor nit, but this sounds better
This operator doesn't handle upstream's completion signal since the state
kept in the closure can be lost. Use [[FlowOps.statefulMap]] instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
