mdedetrich commented on code in PR #628:
URL: https://github.com/apache/incubator-pekko/pull/628#discussion_r1315144720
##########
stream/src/main/scala/org/apache/pekko/stream/scaladsl/Flow.scala:
##########
@@ -1141,7 +1140,19 @@ trait FlowOps[+Out, +Mat] {
*
* @see [[#mapAsync]]
*/
- def mapAsyncUnordered[T](parallelism: Int)(f: Out => Future[T]): Repr[T] =
via(MapAsyncUnordered(parallelism, f))
+ def mapAsyncUnordered[T](parallelism: Int)(f: Out => Future[T]): Repr[T] =
+ // via(MapAsyncUnordered(parallelism, f))
Review Comment:
> I keet it here to help reviewer see the difference.
You can just add a comment on a PR to communicate things like this
##########
stream/src/main/scala/org/apache/pekko/stream/scaladsl/Flow.scala:
##########
@@ -1141,7 +1140,19 @@ trait FlowOps[+Out, +Mat] {
*
* @see [[#mapAsync]]
*/
- def mapAsyncUnordered[T](parallelism: Int)(f: Out => Future[T]): Repr[T] =
via(MapAsyncUnordered(parallelism, f))
+ def mapAsyncUnordered[T](parallelism: Int)(f: Out => Future[T]): Repr[T] =
+ // via(MapAsyncUnordered(parallelism, f))
Review Comment:
> I keet it here to help reviewer see the difference.
You can just add a comment on a PR on a line to communicate things like this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
