He-Pin commented on code in PR #632:
URL: https://github.com/apache/incubator-pekko/pull/632#discussion_r1317178665
##########
multi-node-testkit/src/main/scala/org/apache/pekko/remote/testconductor/Player.scala:
##########
@@ -215,8 +215,9 @@ private[pekko] class ClientFSM(name: RoleName,
controllerAddr: InetSocketAddress
case Event(msg: NetworkOp, _) =>
log.error("received {} instead of Done", msg)
goto(Failed)
- case Event(_: ServerOp, _) =>
- stay().replying(Status.Failure(new IllegalStateException("not connected
yet")))
+ // Scala 3.3.1 compiler says this is unreachable
+ // case Event(_: ServerOp, _) =>
+ // stay().replying(Status.Failure(new IllegalStateException("not
connected yet")))
Review Comment:
Do a swap
```scala
case Event(msg: ServerOp, _) =>
log.error("received {} instead of Done", msg)
goto(Failed)
case Event(_: NetworkOp, _) =>
stay().replying(Status.Failure(new IllegalStateException("not
connected yet")))
```
Done in a separated pr: https://github.com/apache/incubator-pekko/pull/635
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
