He-Pin commented on code in PR #173:
URL:
https://github.com/apache/incubator-pekko-grpc/pull/173#discussion_r1319745730
##########
project/Dependencies.scala:
##########
@@ -102,21 +108,23 @@ object Dependencies {
Compile.scalapbCompilerPlugin,
Protobuf.protobufJava, // or else scalapb pulls older version in
transitively
Compile.grpcProtobuf,
+ Runtime.guava, // forces a newer version than grpc-protobuf defaults too
Review Comment:
I saw this in grpc-java/core
```gradle
implementation libraries.gson,
libraries.android.annotations,
libraries.animalsniffer.annotations,
libraries.errorprone.annotations,
libraries.guava,
```
##########
project/Dependencies.scala:
##########
@@ -102,21 +108,23 @@ object Dependencies {
Compile.scalapbCompilerPlugin,
Protobuf.protobufJava, // or else scalapb pulls older version in
transitively
Compile.grpcProtobuf,
+ Runtime.guava, // forces a newer version than grpc-protobuf defaults too
Review Comment:
Here the guava is a runtime dependency, was it is too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
