raboof commented on PR #708:
URL: https://github.com/apache/incubator-pekko/pull/708#issuecomment-1763337729
> Tentatively, marked as needing a 1.1.0 release. Renaming public methods is
unfortunate but I think this generally ok - the change is useful.
I don't think this is a public method though: it's an inner method inside
the (confusingly named the same) public method. With the change:
```
$ public static void
loadExtensions$(org.apache.pekko.actor.typed.internal.ExtensionsImpl);
public default void loadExtensions();
public static java.lang.Object
$anonfun$loadExtensions$1(org.apache.pekko.actor.typed.internal.ExtensionsImpl,
boolean, java.lang.String);
private void loadExtensionsFor$1(java.lang.String, boolean);
public static org.apache.pekko.actor.typed.ExtensionId
$anonfun$loadExtensions$3(java.lang.Class);
public static scala.util.Try $anonfun$loadExtensions$2(java.lang.Class);
```
even from the Java perspective `loadExtensionsFor` is private, only
`loadExtensions` (unchanged) is public. Mima seems fine with it as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
