mdedetrich opened a new pull request, #279: URL: https://github.com/apache/incubator-pekko-connectors/pull/279
When I originally added this functionality I mistakingly hardcoded the type parameter to `NotUsed` rather than just using `_` (which means don't care). While this may initially seem like a non-issue, a problem eventuates if you happen to use a `Sink` that is contained within a future i.e. `Sink[(UploadPartResponse, immutable.Iterable[C]), Future[Done]]`. Such sinks are quite common and there is no way to get a value outside of a `Future` aside from blocking (which you should never do in production code) in order to satisfy `chunkUploadSink: Sink[(UploadPartResponse, immutable.Iterable[C]), _]`. Note that since `chunkUploadSink` ultimately ends up [getting used in `.alsoTo`](https://github.com/apache/incubator-pekko-connectors/blob/18fc2932cf78194ea149bda0d9e73f7161b8e39f/s3/src/main/scala/org/apache/pekko/stream/connectors/s3/impl/S3Stream.scala#L1323) whos materializer type argument param is also `_` (see https://github.com/apache/incubator-pekko/blob/1b1f57224b409c8b2cbd5267ace814439e97d3ea/stream/src/main/scala/org/apache/pekko/stream/scaladsl/Flow.scala#L3464) and the fact that we are only dealing with type parameters which get erased at runtime means that this change is completely safe for the 1.0.x series (in fact it shouldn't even generate any bytecode difference either way, all this does is make scalac satisfy code where the materializer type param is not `NotUsed`) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
