mdedetrich commented on PR #44: URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/44#issuecomment-1866147935
> @mdedetrich could you consider taking out the 'chore' changes and doing them in a separate PR that we can merge first? > > By chore, I mean the adding of type declarations to implicit vals and things of that nature. Done, see https://github.com/apache/incubator-pekko-persistence-jdbc/pull/94 > @mdedetrich could you also update this PR to use Slick 3.3.0-M5 and Scala 3.3.1? Done Do note that this PR currently breaks binary compatibility so it should only be merged when we have a `1.0.x` branch setup, the PR at https://github.com/apache/incubator-pekko-persistence-jdbc/pull/94 adds the necessary MiMa filters -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
