mdedetrich commented on code in PR #857:
URL: https://github.com/apache/incubator-pekko/pull/857#discussion_r1435522109
##########
actor/src/main/scala-3/org/apache/pekko/util/ByteIterator.scala:
##########
@@ -39,11 +39,11 @@ object ByteIterator {
extends ByteIterator {
iterator =>
- @inline final def len: Int = until - from
+ final def len: Int = until - from
Review Comment:
Well the thing is, I got feedback from the other PR that we should just
remove the `@inline` annotation as its misleading.
I mean I can add the `inline` keyword there, but then I would also retain
the `@inline` annotation which goes against the point of this PR. The whole
premise of this PR is to remove all of the `@inline`/`inline` (aside from the
util wrappers) and if we can demonstrate performance improvements with
`inline`/`@inline` then this can be done in future PR's (and this includes
`@inline` annotations removed in this PR).
So I would recommend doing such a change in a future PR with benchmarks that
demonstrate an improvement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
