mdedetrich commented on PR #857: URL: https://github.com/apache/incubator-pekko/pull/857#issuecomment-1868257372
> I remain skeptical about this. The perf gains are unproven and mainly seem to target the Java user conversions (when most users use Scala). There definitely are performance improvements as it has inlined code that wasn't inlined before, its just a question of whether the code is in a hotspot or not (I am talking about the inliner in general here, not the `org.apache.pekko.util.*` specifically. The scala 2 inliner will automatically inline any code that it sees as slow as long as its considered safe) Also afaik, historically most Akka/Pekko users have been Java and not Scala > > So my vote is -0. If we end up getting build failures in other Pakko modules, I will be arguing for this to be reverted or partially reverted as needed. Sure, Im happy with that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
