samueleresca commented on PR #54: URL: https://github.com/apache/incubator-pekko-site/pull/54#issuecomment-1871316810
> I'm not saying it is a bad idea to copy the files during the build but it is also theoretically possible to just link to the full URLs so that we don't deploy multiple copies of the static files (one set per git repo). Is this something that could be considered? I agree that both approaches have pros and cons. Yes, I think that's possible. At the moment I only moved the static assets defined in `pekko-sbt-paradox` repostiory. There is a whole set of assets that are defined in [paradox-material-theme](https://github.com/jonas/paradox-material-theme). I have double checked in `incubator-pekko-http` by updating `pekko-sbt-paradox` version: `1.0.0+10-9676045b-SNAPSHOT` and I'm seeing the following asset sub-tree in the `target` folder: ``` assets │ ├── fonts │ │ ├── font-awesome.css │ │ ├── material-icons.css │ │ └── specimen │ │ ├── FontAwesome.ttf │ │ ├── FontAwesome.woff │ │ ├── FontAwesome.woff2 │ │ ├── MaterialIcons-Regular.ttf │ │ ├── MaterialIcons-Regular.woff │ │ └── MaterialIcons-Regular.woff2 │ ├── images │ │ └── favicon.png │ ├── javascripts │ │ ├── application.583bbe55.js │ │ ├── modernizr.1aa3b519.js │ │ └── paradox-material-theme.js │ └── stylesheets │ ├── application-palette.22915126.css │ ├── application.451f80e5.css │ └── paradox-material-theme.css ``` If I use the `1.0.0` (at the moment in main) of `pekko-sbt-paradox`, the sub-tree in the `target` folder is: ``` assets │ ├── fonts │ │ ├── font-awesome.css │ │ ├── material-icons.css │ │ └── specimen │ │ ├── FontAwesome.ttf │ │ ├── FontAwesome.woff │ │ ├── FontAwesome.woff2 │ │ ├── MaterialIcons-Regular.ttf │ │ ├── MaterialIcons-Regular.woff │ │ └── MaterialIcons-Regular.woff2 │ ├── images │ │ ├── apache-incubator.svg │ │ ├── favicon.png │ │ ├── pekko_favicon.png │ │ └── pekko_logo.png │ ├── javascripts │ │ ├── application.583bbe55.js │ │ ├── groups.js │ │ ├── modernizr.1aa3b519.js │ │ └── paradox-material-theme.js │ └── stylesheets │ ├── application-palette.22915126.css │ ├── application.451f80e5.css │ ├── paradox-material-theme.css │ └── pekko-theme.css ``` Note that only the following assets are defined in `pekko-sbt-paradox`: - `pekko-theme.css` - `groups.js` `paradox-material-theme.js` (already present in `paradox-material-theme`, but overwritten in `incubator-pekko-site`) - `apache-incubator.svg`, `pekko_favicon.png`, `pekko_logo.png` While the other assets are coming from the material theme: [paradox-material-theme](https://github.com/jonas/paradox-material-theme). Since the [paradox-material-theme](https://github.com/jonas/paradox-material-theme) is no longer maintained, I think it makes sense to plan to merge it into `incubator-pekko-sbt-paradox` / `incubator-pekko-site`. See also the discussion in: https://github.com/apache/incubator-pekko-sbt-paradox/issues/34 So I'm seeing some options here: - (Done in this PR) Move to the CDN the pekko-customized assets. These assets are the ones that we will most likely edit for styling purposes. - Move the other `paradox-material-theme` assets into `incubator-pekko-site`. This would allow to move faster in case we want to fully diverge from the `paradox-material-theme` style in future. Let me know if I'm missing something. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
