mdedetrich commented on PR #316: URL: https://github.com/apache/incubator-pekko-connectors/pull/316#issuecomment-1893409582
> no it won't - not unless there is an explicit dependency in Dependencies.scala - other it will pick up the pekko-http dependency that is in the pom file of pekko-grpc or other pekko-http dependent dependency. Yes but that is the case https://github.com/mdedetrich/incubator-pekko-connectors/blob/99744c0bfbe2680a949b5d79cc5635cf2d02c938/project/Dependencies.scala#L34 is being used as an explicit dependency all throughout pekko connectors. > Could you change PekkoHttpBinaryVersion value? Not to hardcode 1.0. Im doing a PR against sbt-pekko-build to add `binaryVersion` to `PekkoDependency` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
