mdedetrich commented on PR #418: URL: https://github.com/apache/incubator-pekko-http/pull/418#issuecomment-1893447008
> Ok, but what's the rationale for a potential intrusive compilation change if it does not change anything significantly (and we don't track performance changes diligently)? You were probably unavailable at the time when it was being discussed, I think that significantly may not have been the wisest choice of words as it depends on the JDK version (the whole point of the inliner is that it removes the type of Scala bytecode that the JVM doesn't optimize which is more prelevant in earlier JDK's such as 1.8 but from what I gathered most real hotspots have already been handled). Where I disagree is about the intrusive part, the inliner has been used in the most critical parts of Scala ecosystem including scalac itself for many years now (scalac wouldn't use the inliner for no reason), even parboiled2 is using the inliner and most importantly there isn't any regression. Tracking performance diligently is definitely an issue, unfortunately we don't have the best setup for this right now. But ultimately even minor performance gains is still performance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
