mdedetrich commented on PR #983: URL: https://github.com/apache/incubator-pekko/pull/983#issuecomment-1901324618
So I have done my own benchmarks which you can see here https://www.diffchecker.com/EGNbOWui/, left is the unoptimized version and right is optimized. There probably is a difference albeit its small however I wouldn't put too much importance to my benchmarks due to it being run on the M1 laptop. In general I am not against the merit of the PR since the whole tenet of Akka/Pekko is as fast performance as you can get even if its at the cost of code readability and there is an entire history of such changes being made in Akka. In other words one of the primary reasons why people use Akka/Pekko is because its fast and not that its written in perfect idiomatic Scala. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
