laglangyue commented on PR #997: URL: https://github.com/apache/incubator-pekko/pull/997#issuecomment-1902118336
LGTM，BTW，I took a look at the method above and it seems that it can also be optimized, `org.apache.pekko.remote.artery.tcp.ssl.PemManagersProvider#loadPrivateKey` can use `java.util.Base64.Decoder#decode(byte[]))`，not need to new `String()` and decode, ...I'm not sure if it's possible -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
