He-Pin commented on code in PR #990:
URL: https://github.com/apache/incubator-pekko/pull/990#discussion_r1460973722
##########
stream-tests/src/test/scala/org/apache/pekko/stream/DslFactoriesConsistencySpec.scala:
##########
@@ -41,8 +41,9 @@ class DslFactoriesConsistencySpec extends AnyWordSpec with
Matchers {
"futureFlow", // completionStageFlow
"futureSink", // completionStageSink
"lazyFutureSink", // lazyCompletionStageSink
- "createGraph" // renamed/overload of create for getting type inference
working in Scala 3
- )
+ "createGraph", // renamed/overload of create for getting type inference
working in Scala 3
+ // We box Scala Boolean to Java Boolean for better user experience
+ "exists")
Review Comment:
Can this be fixed with a mapping in `scala -> java types`
##########
stream-tests/src/test/scala/org/apache/pekko/stream/DslFactoriesConsistencySpec.scala:
##########
@@ -41,8 +41,9 @@ class DslFactoriesConsistencySpec extends AnyWordSpec with
Matchers {
"futureFlow", // completionStageFlow
"futureSink", // completionStageSink
"lazyFutureSink", // lazyCompletionStageSink
- "createGraph" // renamed/overload of create for getting type inference
working in Scala 3
- )
+ "createGraph", // renamed/overload of create for getting type inference
working in Scala 3
+ // We box Scala Boolean to Java Boolean for better user experience
+ "exists")
Review Comment:
Can this be fixed with a mapping in `scala -> java types`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
