pjfanning commented on code in PR #485:
URL: https://github.com/apache/incubator-pekko/pull/485#discussion_r1464994713
##########
actor/src/main/resources/reference.conf:
##########
@@ -482,6 +482,10 @@ pekko {
# Setting to "FIFO" to use queue like peeking mode which "poll" or
"LIFO" to use stack
# like peeking mode which "pop".
task-peeking-mode = "FIFO"
+
+ # This config is new in Pekko v1.1.0 and only has an effect if you are
running with JDK 9 and above.
+ # Read the documentation on `java.util.concurrent.ForkJoinPool` to
find out more. Default in hex is 0x7fff.
+ maximum-pool-size = 32767
Review Comment:
I'm not sure what these comments mean. If someone wants changes, can they
provide actual code. I can interpret code more easily than abstract comments.
I have read and re-read the ForkJoinPool code and if we use the old Java
constructor (as opposed to the new one added in Java 9) - that the old
constructor calls the new constructor and passes the value of MAX_CAP for the
maxPoolSizeValue. MAX_CAP=0x7fff which is 32767.
I will make changes if I am wrong but please use code and code links to show
me where I am going wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
