pjfanning commented on code in PR #216:
URL:
https://github.com/apache/incubator-pekko-grpc/pull/216#discussion_r1465632686
##########
build.sbt:
##########
@@ -32,6 +32,11 @@ commands := commands.value.filterNot { command =>
ThisBuild / reproducibleBuildsCheckResolver := Resolver.ApacheMavenStagingRepo
+// So that gRPC is properly styled
+ThisBuild / apacheSonatypeArtifactNameProcessor :=
apacheSonatypeArtifactNameProcessor.value.andThen {
+ _.replaceAll("Grpc", "gRPC")
Review Comment:
the built plugin title cases the name - so Grpc is what is expected - making
ths case insensitive is complicated and not worth the hassle
##########
build.sbt:
##########
@@ -32,6 +32,11 @@ commands := commands.value.filterNot { command =>
ThisBuild / reproducibleBuildsCheckResolver := Resolver.ApacheMavenStagingRepo
+// So that gRPC is properly styled
+ThisBuild / apacheSonatypeArtifactNameProcessor :=
apacheSonatypeArtifactNameProcessor.value.andThen {
+ _.replaceAll("Grpc", "gRPC")
Review Comment:
the built plugin title cases the name - so Grpc is what is expected - making
this case insensitive is complicated and not worth the hassle
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
