mdedetrich commented on PR #485: URL: https://github.com/apache/incubator-pekko/pull/485#issuecomment-1909239487
@He-Pin Argument would be a lot more convincing if creating a JDK 9 `ForkJoinPool` would be impossible which is not the case. Although having it default to the better version of JDK9+ would be nice, its also not a deal breaker and we can also document this as a stop gap. The reason I am hesitant is that the current Pekko build with all of the JDK9 classes, multi-jvm etc etc is a bit of a mess, note that I am _**NOT**_ blaming anyone specifically here, there are legitimate reasons for this mess, i.e. Akka was a really old sbt project that had to implement various workarounds which are no longer needed but those workarounds were still left in the code and then there is the case of working around even current day sbt limitations which is what is causing the sbt-osgi problems. In short I would like to start devoting actual effort to cleaning up the sbt build which is something that I have already started doing rather than dumping additional features that involve non trivial changes to the build which then end up causing regressions (either at the start or later down the track due to how the build interactions work). sbt-osgi is a good example of this, I took initiate/responsibility to get it working and as you can see we are still getting problems 3-4 months down the track. We need to be more strategic/intelligent about what features we push and for this feature specifically I would prefer if we actually put it on hold until I figure out and then stabilize all of the sbt-multi-jar/sbt-multi-jvm/sbt-osgi interactions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
