mdedetrich commented on issue #1040: URL: https://github.com/apache/incubator-pekko/issues/1040#issuecomment-1911438063
@Roiocam Since your fix is more correct maybe you can also apply a similar fix instead of what was done in https://github.com/apache/incubator-pekko/pull/920, i.e. instead of adding the sbt-assembly jar to `OsgiKeys.explodedJars` as was done at https://github.com/apache/incubator-pekko/pull/920/files#diff-49fc9a69964c909b343968bdcb2de99b610b6122ec40900ccab4f2e532f2915aR84-R90, instead you can modify the `dependencyClasspathAsJars` as you did in your PR at https://github.com/apache/incubator-pekko/pull/1047/files#diff-378ca99a990595050ef83c6d976edc6e26e23b49622c4bd3ca5acda8bfb411ffR58 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
