pjfanning commented on code in PR #445: URL: https://github.com/apache/incubator-pekko-http/pull/445#discussion_r1468491333
########## http-tests/src/test/scala/org/apache/pekko/http/scaladsl/server/directives/FileAndResourceDirectivesSymlinkSpec.scala: ########## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * license agreements; and to You under the Apache License, version 2.0: + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * This file is part of the Apache Pekko project, which was derived from Akka. + */ + +/* + * Copyright (C) 2009-2022 Lightbend Inc. <https://www.lightbend.com> + */ + +package org.apache.pekko.http.scaladsl.server +package directives + +import java.io.File +import java.nio.file.{ Files, Paths } + +import scala.concurrent.duration._ + +import org.apache.pekko +import pekko.http.scaladsl.testkit.RouteTestTimeout +import pekko.testkit._ + +import org.scalatest.{ BeforeAndAfterAll, Inside, Inspectors } + +class FileAndResourceDirectivesSymlinkSpec extends RoutingSpec + with Inspectors with Inside with BeforeAndAfterAll { + + // need to serve from the src directory, when sbt copies the resource directory over to the + // target directory it will resolve symlinks in the process + val testRoot = new File("http-tests/src/test/resources") Review Comment: @He-Pin I created https://github.com/apache/incubator-pekko-http/issues/446 - is ok to say that you are not blocking this? I would like to get this merged so that I can do an RC2 for the Pekko HTTP 1.0.1 release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
