injae-kim commented on code in PR #1053:
URL: https://github.com/apache/incubator-pekko/pull/1053#discussion_r1468506714
##########
stream-tests/src/test/java/org/apache/pekko/stream/javadsl/FlowTest.java:
##########
@@ -237,6 +238,22 @@ public void mustBeAbleToUseMapWithResource() {
Assert.assertFalse(gate.get());
}
+ @Test
+ public void mustBeAbleToUseMapWithAutoCloseableResource() {
+ final AtomicInteger closed = new AtomicInteger();
+ Source.from(Arrays.asList("1", "2", "3"))
+ .via(
+ Flow.of(String.class)
+ .mapWithResource(
+ () -> (AutoCloseable) closed::incrementAndGet,
+ (resource, elem) -> elem))
+ .runWith(TestSink.create(system), system)
+ .request(4)
+ .expectNext("1", "2", "3")
+ .expectComplete();
+ Assert.assertEquals(closed.get(), 3);
Review Comment:
✅ updated
##########
stream/src/main/scala/org/apache/pekko/stream/javadsl/Flow.scala:
##########
@@ -828,6 +828,44 @@ final class Flow[In, Out, Mat](delegate: scaladsl.Flow[In,
Out, Mat]) extends Gr
(resource, out) => f(resource, out),
resource => close.apply(resource).toScala))
+ /**
+ * Transform each stream element with the help of a [[AutoCloseable]]
resource and close it.
Review Comment:
✅ updated!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
