He-Pin commented on code in PR #1054: URL: https://github.com/apache/incubator-pekko/pull/1054#discussion_r1468513595
########## project/Jdk9.scala: ########## @@ -11,36 +11,87 @@ * Copyright (C) 2017-2022 Lightbend Inc. <https://www.lightbend.com> */ -import sbt._ import sbt.Keys._ +import sbt._ object Jdk9 extends AutoPlugin { import JdkOptions.notOnJdk8 + // The version 9 is special for any Java versions >= 9 + // and the version 11 is special for any Java versions >= 11 + // and the version 17 is special for any Java versions >= 17 + // and the version 21 is special for any Java versions >= 21 + private val supportedJavaLTSVersions = List("9", "11", "17", "21") + lazy val CompileJdk9 = config("CompileJdk9").extend(Compile) lazy val TestJdk9 = config("TestJdk9").extend(Test).extend(CompileJdk9) - val SCALA_SOURCE_DIRECTORY = "scala-jdk-9" - val SCALA_TEST_SOURCE_DIRECTORY = "scala-jdk9-only" - val JAVA_SOURCE_DIRECTORY = "java-jdk-9" - val JAVA_TEST_SOURCE_DIRECTORY = "java-jdk9-only" + lazy val SCALA_SOURCE_DIRECTORY = getAdditionalSourceDirectoryNames("scala", isTest = false) + lazy val SCALA_TEST_SOURCE_DIRECTORY = getAdditionalSourceDirectoryNames("scala", isTest = true) + + lazy val JAVA_SOURCE_DIRECTORY = getAdditionalSourceDirectoryNames("java", isTest = false) Review Comment: Change it directly, I just back to my home, very bad network. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
