jrudolph opened a new pull request, #456: URL: https://github.com/apache/incubator-pekko-http/pull/456
As the official documentation prominently states, the inliner is unsafe to use with incremental compilation (see https://github.com/sbt/zinc/issues/537). This leads to hard to diagnose issues during development. It also massively inflates compile times (e.g. 16s -> 44s for http-core) making development much more painful than necessary. Real world demonstration of correctness issues: * Add `private def doPull2(): ResponseOutput = MessageEnd` below `onPull` in HttpResponseParser.scala * `clean` and `compile` * Run tests in `HttpsProxyGraphStageSpec` * change `onPull` in `HttpResponseParser` to call `doPull2` instead of `doPull` (now doing incremental compilation) * Run tests in `HttpsProxyGraphStageSpec`, despite the broken implementation the test still completes fine -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
