He-Pin commented on code in PR #1053:
URL: https://github.com/apache/incubator-pekko/pull/1053#discussion_r1471665460
##########
stream-tests/src/test/scala/org/apache/pekko/stream/scaladsl/FlowMapWithResourceSpec.scala:
##########
@@ -518,6 +518,118 @@ class FlowMapWithResourceSpec extends
StreamSpec(UnboundedMailboxConfig) {
closedCounter.get shouldBe 1
}
+ "continue with autoCloseable when Strategy is Resume and exception
happened" in {
+ val closedCounter = new AtomicInteger(0)
+ val create = () =>
+ new AutoCloseable {
+ override def close(): Unit = closedCounter.incrementAndGet()
+ }
+ val p = Source
+ .fromIterator(() => (0 to 50).iterator)
+ .mapWithResource(create,
+ (_: AutoCloseable, elem) => {
+ if (elem == 10) throw TE("") else elem
+ })
+ .withAttributes(supervisionStrategy(resumingDecider))
+ .runWith(Sink.asPublisher(false))
+ val c = TestSubscriber.manualProbe[Int]()
+
+ p.subscribe(c)
+ val sub = c.expectSubscription()
+
+ (0 to 48).foreach(i => {
+ sub.request(1)
+ c.expectNext() should ===(if (i < 10) i else i + 1)
+ })
+ sub.request(1)
+ c.expectNext(50)
+ c.expectComplete()
+ closedCounter.get shouldBe 1
+ }
+
+ "continue with autoCloseable when Strategy is Resume and exception
happened on map" in {
+ val closedCounter = new AtomicInteger(0)
+ val create = () =>
+ new AutoCloseable {
+ override def close(): Unit = closedCounter.incrementAndGet()
+ }
+ val p = Source
+ .fromIterator(() => (0 to 50).iterator)
+ .mapWithResource(create, (_: AutoCloseable, elem) => elem)
+ .map(elem => {
+ if (elem == 10) throw TE("") else elem
Review Comment:
This is not right, @pjfanning 's map means the block inside
`mapWithResource`:)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
