mdedetrich commented on PR #1085:
URL: https://github.com/apache/incubator-pekko/pull/1085#issuecomment-1919593717
> * mima is complaining
```
[error] pekko-actor: Failed binary compatibility check against
org.apache.pekko:pekko-actor_2.12:1.0.0! Found 1 potential problems
[error] * abstract method asInputStream()java.io.InputStream in class
org.apache.pekko.util.ByteString is present only in current version
[error] filter with:
ProblemFilters.exclude[ReversedMissingMethodProblem]("org.apache.pekko.util.ByteString.asInputStream")
```
This is a forward compatibility error and is expected, i.e. MiMa complains
when you add a new method to a public interface
> * should some benchmarks be written?
Yes they should
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
