mdedetrich commented on PR #470: URL: https://github.com/apache/incubator-pekko-http/pull/470#issuecomment-1926241761
@jrudolph @raboof So I had a quick look at this and I don't know what to do here, it seems like making `getFirst` deprecated was a mistake or maybe it should only be deprecated for public and not private inter-pekko use cases? The whole reason why `getFirst` is necessary is so that the `withSizeLimit` directive works correctly with [nested routes](https://github.com/apache/incubator-pekko-http/blob/c5eda6a5d6182c2f6432e6c891ce263ae2e5d8aa/http-tests/src/test/scala/org/apache/pekko/http/scaladsl/server/directives/MiscDirectivesSpec.scala#L148-L185) and while it is possible to remove the deprecation of `getFirst` without using `get` in doing so it would just involve copying the implementation of it which means its not really solving a problem? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
