wjohnsonbynder commented on issue #105: URL: https://github.com/apache/incubator-pekko-persistence-jdbc/issues/105#issuecomment-1934416212
A bit out of my depth with for the project but I messed around with the following test with both the existing code and my fix. Run locally https://github.com/apache/incubator-pekko-persistence-jdbc/blob/69a80e3259e0a625ee99f247b1f6ec00276408da/core/src/test/scala/org/apache/pekko/persistence/jdbc/query/EventsByTagTest.scala#L211 I ran it with 100, 1000 and 1300 actors with both old select and my fix. More than the tests were timing out locally. Old followed by new 100 - old: 3.708s new: 2.370s 1000 - old: 30.447s new: 8.902s 1300 - old: 53.257s new: 12.082s The other tests all run about the same as the size of the data is small. Since this is an error with selecting the whole table, it really only shows up at scale. Should I go ahead and make a PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
