pjfanning commented on code in PR #107:
URL:
https://github.com/apache/incubator-pekko-projection/pull/107#discussion_r1486024395
##########
slick/src/main/scala/org/apache/pekko/projection/slick/internal/SlickProjectionImpl.scala:
##########
@@ -198,7 +198,7 @@ private[projection] class SlickProjectionImpl[Offset,
Envelope, P <: JdbcProfile
databaseConfig.db.run(offsetStore.saveOffset(projectionId,
offset)).map(_ => Done)
private[projection] def newRunningInstance(): RunningProjection =
- new SlickRunningProjection(RunningProjection.withBackoff(() =>
mappedSource(), settings), this)
+ new SlickRunningProjection(RunningProjection.withBackoff(() =>
this.mappedSource(), settings), this)
Review Comment:
build issue after updating to scala 2.13.12
```
[error]
/home/runner/work/incubator-pekko-projection/incubator-pekko-projection/slick/src/main/scala/org/apache/pekko/projection/slick/internal/SlickProjectionImpl.scala:201:70:
reference to mappedSource is ambiguous;
[error] it is both defined in the enclosing class SlickProjectionImpl and
inherited in the enclosing class SlickInternalProjectionState as method
mappedSource (defined in class InternalProjectionState)
[error] In Scala 2, symbols inherited from a superclass shadow symbols
defined in an outer scope.
[error] Such references are ambiguous in Scala 3. To continue using the
inherited symbol, write `this.mappedSource`.
[error] Or use `-Wconf:msg=legacy-binding:s` to silence this warning.
[quickfixable]
[error] new SlickRunningProjection(RunningProjection.withBackoff(() =>
mappedSource(), settings), this)
[error]
^
[error] one error found
[error] (slick / Compile / compileIncremental) Compilation failed
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
