mdedetrich commented on code in PR #1125:
URL: https://github.com/apache/incubator-pekko/pull/1125#discussion_r1491966858
##########
project/Protobuf.scala:
##########
@@ -38,7 +38,7 @@ object Protobuf {
outputPaths := Seq((Compile / sourceDirectory).value, (Test /
sourceDirectory).value).map(_ / "java"),
importPath := None,
// this keeps intellij happy for files that use the shaded protobuf
- Compile / unmanagedJars += (LocalProject("protobuf-v3") / assembly).value,
+ Compile / unmanagedJars += (LocalProject("protobuf-v3") / Compile /
packageBin).value,
Review Comment:
This to me also looks suspicious, @Duhemm whats the context behind this
change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
