raboof commented on code in PR #222:
URL:
https://github.com/apache/incubator-pekko-grpc/pull/222#discussion_r1495869528
##########
runtime/src/main/scala/org/apache/pekko/grpc/internal/PekkoDiscoveryNameResolverProvider.scala:
##########
@@ -34,8 +35,7 @@ class PekkoDiscoveryNameResolverProvider(
override def getDefaultScheme: String = "http"
- override def newNameResolver(targetUri: URI, args: NameResolver.Args):
PekkoDiscoveryNameResolver = {
- require(targetUri.getAuthority != null, s"target uri should not have null
authority, got [$targetUri]")
- new PekkoDiscoveryNameResolver(discovery, defaultPort,
targetUri.getAuthority, portName, protocol, resolveTimeout)
- }
+ override def newNameResolver(targetUri: URI, args: NameResolver.Args):
PekkoDiscoveryNameResolver =
+ new PekkoDiscoveryNameResolver(discovery, defaultPort, serviceName,
portName, protocol, resolveTimeout)
Review Comment:
Hmm, that is slightly scary (I assume the assert was there for a reason),
but if you're confident this is a correct fix then :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
