Roiocam commented on code in PR #126:
URL:
https://github.com/apache/incubator-pekko-sbt-paradox/pull/126#discussion_r1510511451
##########
theme/src/main/assets/page.st:
##########
@@ -46,7 +46,7 @@ $!
$ elseif (page.properties.("material.author")) $
<meta name="author" content="$page.properties.("site.author")$">
$ endif $
- <link rel="shortcut icon"
href="$page.base$$page.properties.("material.favicon")$">
+ <link rel="shortcut icon"
href="$page.properties.("assets.hostname")$$page.base$$page.properties.("material.favicon")$">
Review Comment:
The icon link of all modules is broken, but the pekko homepage is not, which
also proves this. `$page.base$` is the path of a specific project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
