pjfanning commented on code in PR #519:
URL: https://github.com/apache/pekko-http/pull/519#discussion_r1541549132
##########
http-marshallers-java/http-jackson/src/main/java/org/apache/pekko/http/javadsl/marshallers/jackson/Jackson.java:
##########
@@ -113,7 +116,28 @@ static ObjectMapper createMapper(final Config config) {
JsonFactory.builder()
.streamReadConstraints(streamReadConstraints)
.streamWriteConstraints(streamWriteConstraints)
+ .recyclerPool(getBufferRecyclerPool(config))
.build();
return new JsonMapper(jsonFactory);
}
+
+ private static RecyclerPool<BufferRecycler> getBufferRecyclerPool(final
Config cfg) {
+ switch (cfg.getString("buffer-recycler.pool-instance")) {
Review Comment:
it is defaulted in reference.conf - virtually every config would blow up if
we didn't have defaults - nowhere do we need to check for them not being set -
because we have defaults in reference.conf
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
