pjfanning commented on code in PR #1246:
URL: https://github.com/apache/pekko/pull/1246#discussion_r1546400094
##########
cluster-sharding/src/main/scala/org/apache/pekko/cluster/sharding/external/ExternalShardAllocationStrategy.scala:
##########
@@ -39,11 +39,35 @@ import pekko.cluster.sharding.ShardRegion.ShardId
import pekko.event.Logging
import pekko.pattern.AskTimeoutException
import pekko.util.Timeout
+import pekko.util.JavaDurationConverters._
object ExternalShardAllocationStrategy {
type ShardRegion = ActorRef
+ /**
+ * Create an [[ExternalShardAllocationStrategy]]
+ */
+ def apply(systemProvider: ClassicActorSystemProvider, typeName: String):
ExternalShardAllocationStrategy = {
+ implicit val timeout: Timeout = 5.seconds
+ new ExternalShardAllocationStrategy(systemProvider, typeName)
+ }
+
+ /**
+ * Scala API: Create an [[ExternalShardAllocationStrategy]]
+ */
Review Comment:
I don't see why this should be removed. There are plenty of other docs that
includes this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
