mdedetrich commented on code in PR #134: URL: https://github.com/apache/pekko-projection/pull/134#discussion_r1554889041
########## .git-blame-ignore-revs: ########## @@ -4,3 +4,6 @@ af0dc3cc8635a1f5a7760bbdcc6259559d70c77a # manual 11b119182338cb43cd45f5849684818be61ee493 ebead18d8114832ebe4f9d7196686af087fb2507 + +# Scala Steward: Reformat with sbt-java-formatter 0.8.0 +57b0d25b6ec89871ec0c3eb50b5868a14d46e764 Review Comment: So I a bit late to this whole thing, but the way that historically dealt with `.git-blame-ignore-revs` is that we only add a commit hash to that file after the PR that does the formatting is merged. That way the formatting PR can have a nice clean git log (i.e. a single "atomic" commit that **only** applies the formatting change that is a separate from the other commits), that PR is then merged and then a new PR is made which adds that single formatting commit to `.git-blame-ignore-revs` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
