GitHub user pjfanning added a comment to the discussion: Add new deleteObject functions to Persistence API
@Roiocam @He-Pin https://github.com/apache/pekko-persistence-jdbc/pull/156/ isn't exactly un take of these changes. In PR156, I just use DurableStateStoreException as this PR is not published yet. That PR makes me think I want to revisit the design a bit. * The check in PR156 to decide on what type of exception to throw when the delete doesn't work - I think this has a race condition because the state could change because a different concurrent process updates the object after the delete attempt * So I think we just need one exception a RevisionDeleteExecption which is thrown if the delete does nothing and no attempt is made to work out why the delete failed * One other thing is that PR156 causes me to add a dependency in pekko-persistence-jdbc on pekko-persistence-typed - is this ok? There is an argument that the new exception could be put in the pekko-persistence jar and DurableStateStoreException could be made into a subclass of a shared parent exception. GitHub link: https://github.com/apache/pekko/discussions/1233#discussioncomment-9104660 ---- This is an automatically sent email for notifications@pekko.apache.org. To unsubscribe, please send an email to: notifications-unsubscr...@pekko.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
