pjfanning commented on code in PR #1247:
URL: https://github.com/apache/pekko/pull/1247#discussion_r1565869234
##########
actor/src/main/scala-2.12/org/apache/pekko/util/ByteIterator.scala:
##########
@@ -470,7 +470,7 @@ abstract class ByteIterator extends BufferedIterator[Byte] {
override def indexWhere(p: Byte => Boolean): Int = indexWhere(p, 0)
override def indexWhere(p: Byte => Boolean, from: Int): Int = {
var index = 0
- while (index < from) {
+ while (index < from && hasNext) {
Review Comment:
if there is a bug in ByteIterator, could the bug fix be in a separate PR? It
needs to have its own release note and may be backported to 1.0.x,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
