He-Pin commented on code in PR #537:
URL: https://github.com/apache/pekko-http/pull/537#discussion_r1571248401
##########
docs/src/test/scala/docs/http/scaladsl/HttpClientExampleSpec.scala:
##########
@@ -13,31 +13,27 @@
package docs.http.scaladsl
-import scala.concurrent.ExecutionContext
-import org.apache.pekko
-import pekko.http.scaladsl.model.HttpRequest
-import pekko.http.scaladsl.settings.ClientConnectionSettings
-import pekko.http.scaladsl.settings.ConnectionPoolSettings
-import scala.annotation.nowarn
import docs.CompileOnlySpec
+import org.apache.pekko
import org.scalatest.matchers.should.Matchers
Review Comment:
Yes, sort it with idea or sortimports
##########
docs/src/test/scala/docs/http/scaladsl/Http2ClientApp.scala:
##########
@@ -75,28 +74,31 @@ object Http2ClientApp extends App {
.flatMap(_.toStrict(1.second))
.onComplete(res => println(s"[4] Got favicon: $res"))
- // OverflowStrategy.dropNew has been deprecated in latest Pekko versions
- // FIXME: replace with 2.6 queue when 2.5 support is dropped, see #3069
- @nowarn("msg=Use Source.queue") //
// #response-future-association
def singleRequest(
connection: Flow[HttpRequest, HttpResponse, Any], bufferSize: Int =
100): HttpRequest => Future[HttpResponse] = {
- val queue =
- Source.queue(bufferSize, OverflowStrategy.dropNew)
+ val queue = {
Review Comment:
The {} is not needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
