Roiocam commented on code in PR #1305:
URL: https://github.com/apache/pekko/pull/1305#discussion_r1584240640
##########
cluster-sharding-typed/src/main/scala/org/apache/pekko/cluster/sharding/typed/internal/ClusterShardingImpl.scala:
##########
@@ -194,12 +194,9 @@ import pekko.util.JavaDurationConverters._
typeKey.name,
new java.util.function.Function[String,
ActorRef[scaladsl.ClusterSharding.ShardCommand]] {
override def apply(t: String):
ActorRef[scaladsl.ClusterSharding.ShardCommand] = {
- // using classic.systemActorOf to avoid the Future[ActorRef]
- system.toClassic
- .asInstanceOf[ExtendedActorSystem]
- .systemActorOf(
Review Comment:
The before code didn't return ActorRef with typed? looks like a bug too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
