Roiocam commented on code in PR #192:
URL: 
https://github.com/apache/pekko-persistence-jdbc/pull/192#discussion_r1604284994


##########
migrator-integration-test/src/test/scala/org/apache/pekko/persistence/jdbc/migrator/integration/JournalMigratorTest.scala:
##########
@@ -19,4 +19,5 @@ class MySQLJournalMigratorTest extends 
JournalMigratorTest("mysql-application.co
 
 class OracleJournalMigratorTest extends 
JournalMigratorTest("oracle-application.conf") with OracleCleaner
 
-class SqlServerJournalMigratorTest extends 
JournalMigratorTest("sqlserver-application.conf") with SqlServerCleaner
+// ignore this because SQLServer didn't support Slick forceInsert
+// class SqlServerJournalMigratorTest extends 
JournalMigratorTest("sqlserver-application.conf") with SqlServerCleaner

Review Comment:
   Would you take a look at this? The exception is:
   
   ```
   Caused by: com.microsoft.sqlserver.jdbc.SQLServerException: 
   
   Cannot insert explicit value for identity column in table 'event_journal' 
when IDENTITY_INSERT is set to OFF.
   ```



##########
migrator-integration-test/src/test/scala/org/apache/pekko/persistence/jdbc/migrator/integration/JournalMigratorTest.scala:
##########
@@ -19,4 +19,5 @@ class MySQLJournalMigratorTest extends 
JournalMigratorTest("mysql-application.co
 
 class OracleJournalMigratorTest extends 
JournalMigratorTest("oracle-application.conf") with OracleCleaner
 
-class SqlServerJournalMigratorTest extends 
JournalMigratorTest("sqlserver-application.conf") with SqlServerCleaner
+// ignore this because SQLServer didn't support Slick forceInsert
+// class SqlServerJournalMigratorTest extends 
JournalMigratorTest("sqlserver-application.conf") with SqlServerCleaner

Review Comment:
   @laglangyue Would you take a look at this? The exception is:
   
   ```
   Caused by: com.microsoft.sqlserver.jdbc.SQLServerException: 
   
   Cannot insert explicit value for identity column in table 'event_journal' 
when IDENTITY_INSERT is set to OFF.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to