Roiocam commented on code in PR #1336: URL: https://github.com/apache/pekko/pull/1336#discussion_r1629492867
########## persistence-typed-tests/src/test/scala/org/apache/pekko/persistence/typed/scaladsl/EventSourcedStashOverflowSpec.scala: ########## @@ -55,10 +55,11 @@ object EventSourcedStashOverflowSpec { SteppingInmemJournal.config("EventSourcedStashOverflow").withFallback(ConfigFactory.parseString(s""" pekko.persistence { typed { - stash-capacity = 1000 # enough to fail on stack size + stash-capacity = 2000 # enough to fail on stack size Review Comment: That's will cause more stack trace frame, that will event worst. Maybe we could unstash with counter, after limitation, we will start another recursion(clear stack) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org