He-Pin commented on code in PR #167:
URL: https://github.com/apache/pekko-projection/pull/167#discussion_r1636041690
##########
slick/src/main/scala/org/apache/pekko/projection/slick/internal/SlickOffsetStore.scala:
##########
@@ -35,29 +35,32 @@ import pekko.projection.jdbc.internal.MySQLDialect
import pekko.projection.jdbc.internal.OracleDialect
import pekko.projection.jdbc.internal.PostgresDialect
import pekko.util.Helpers.toRootLowerCase
+import slick.basic.DatabaseConfig
import slick.jdbc.JdbcProfile
/**
* INTERNAL API
*/
@InternalApi private[projection] class SlickOffsetStore[P <: JdbcProfile](
system: ActorSystem[_],
- val db: P#Backend#Database,
- val profile: P,
+ val databaseConfig: DatabaseConfig[P],
Review Comment:
yes, I think this change is fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
