pjfanning commented on code in PR #259:
URL: https://github.com/apache/pekko-management/pull/259#discussion_r1642662092
##########
discovery-aws-api-async/src/main/scala/org/apache/pekko/discovery/awsapi/ecs/AsyncEcsTaskSetDiscovery.scala:
##########
@@ -54,7 +54,8 @@ class AsyncEcsTaskSetDiscovery(system: ActorSystem) extends
ServiceDiscovery {
private val cluster = config.getString("cluster")
private lazy val ecsClient = {
- val conf =
ClientOverrideConfiguration.builder().retryPolicy(RetryPolicy.none).build()
+ val retryStrategy =
DefaultStandardRetryStrategy.builder().maxAttempts(0).build()
Review Comment:
That's the point I made in
https://github.com/apache/pekko-management/pull/259#issuecomment-2171126135
I'd prefer to remove this retryStrategy and use the default retry setup - or
to explicitly add a retry strategy that actually retries.
But this requires discussion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
